fix: app subprocess restart not running onEnable lifecycle #34172
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63c7241 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34172 +/- ##
========================================
Coverage 75.79% 75.79%
========================================
Files 511 511
Lines 22132 22132
Branches 5394 5394
========================================
Hits 16775 16775
Misses 4709 4709
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
KevLehman
approved these changes
Dec 12, 2024
|
/backport 7.0.2 |
1 similar comment
|
/backport 7.0.2 |
|
/bark |
1 similar comment
|
/bark |
|
AU AU |
|
/backport 7.0.2 |
|
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands: after that just run |
d-gubert
added a commit
that referenced
this pull request
Dec 12, 2024
|
/backport 7.0.2 |
|
Pull request #34173 added to Project: "Patch 7.0.2" |
d-gubert
added a commit
to RocketChat/Rocket.Chat.Apps-engine
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
onEnableon the subprocess restart if the app is enabledIssue(s)
Steps to test or reproduce
Further comments